removing final to enable mocking this class

[csokol]

Since this class its hard to instantiate, it should not be final so that we can mock it for testing.

I'm trying to update vraptor-plugin-hibernate4 and we need to mock Parameter class in its tests.

btw, we have two repositories for vraptor-plugin-hibernate4, the one in @garcia-jj and in @caelum, I'm developing in the caelum repo...

[garcia-jj]

The problem is that Parameter from Java 8 is final, and the proposal for this is to be closer to Java 8. Changing this the tests will break in Java 8 environments.

[csokol]

Well... any ideas on how to intantiate this class for testing? I don't want
to provide a real AccessibleObject instance or to mock full Constructor or
Method methods...

Chico Sokol

On Wed, Nov 6, 2013 at 11:05 AM, Otávio Garcia notifications@gitpro.ttaallkk.topwrote:

In vraptor-core/src/main/java/br/com/caelum/vraptor/http/Parameter.java:

@@ -13,7 +13,7 @@
*

• @author Otávio Scherer Garcia
  */
  -public final class Parameter implements AnnotatedElement {
  +public class Parameter implements AnnotatedElement {

The problem is that Parameter from Java 8 is final, and the proposal for
this is to be closer to Java 8. Changing this the tests will break in Java
8 environments.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/250/files#r7462564
.

[garcia-jj]

I think better... we can change this removing final. Java 8 allow us to use Method.getParameters without using ParameterNameProvider, so these classes will be removed.

Ship this :)

[csokol]

\o/

Chico Sokol

On Wed, Nov 6, 2013 at 11:26 AM, Otávio Garcia notifications@gitpro.ttaallkk.topwrote:

In vraptor-core/src/main/java/br/com/caelum/vraptor/http/Parameter.java:

@@ -13,7 +13,7 @@
*

• @author Otávio Scherer Garcia
  */
  -public final class Parameter implements AnnotatedElement {
  +public class Parameter implements AnnotatedElement {

I think better... we can change this removing final. Java 8 allow us to
use Method.getParameters without using ParameterNameProvider, so these
classes will be removed.

Ship this :)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/250/files#r7462938
.