-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload observing instead of intercepting #256
Upload observing instead of intercepting #256
Conversation
|
||
@Override | ||
public void intercept(InterceptorStack stack, ControllerMethod method, Object controllerInstance) { | ||
public void upload(@Observes ControllerMethod controllerMethod) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the correct event? wasn't something like ReadyToExecute
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need run it before ParameterInstantiatorInterceptor
, ReadyToExecute
is fired after
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.. where is it being fired? what else is observing this event?
ControllerMethod is not an event, it's a product of one. Maybe we should wrap it in another class...
Just maybe ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.. where is it being fired? what else is observing this event?
fired by ControllerLookupInterceptor,
observed by ControllerMethodFactory, NullMultipart and CommonsUploadMultipart
Maybe we should wrap it in another class...
I think about that before using ControllerMethod directly, do you have a good name for this new event?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something like ControllerMethodDiscovered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done here 775a81b
Upload observing instead of intercepting
#247