Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload observing instead of intercepting #256

Conversation

Turini
Copy link
Member

@Turini Turini commented Nov 13, 2013

@ghost ghost assigned Turini Nov 13, 2013

@Override
public void intercept(InterceptorStack stack, ControllerMethod method, Object controllerInstance) {
public void upload(@Observes ControllerMethod controllerMethod) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the correct event? wasn't something like ReadyToExecute?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need run it before ParameterInstantiatorInterceptor, ReadyToExecute is fired after

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.. where is it being fired? what else is observing this event?

ControllerMethod is not an event, it's a product of one. Maybe we should wrap it in another class...

Just maybe ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.. where is it being fired? what else is observing this event?

fired by ControllerLookupInterceptor,
observed by ControllerMethodFactory, NullMultipart and CommonsUploadMultipart

Maybe we should wrap it in another class...

I think about that before using ControllerMethod directly, do you have a good name for this new event?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something like ControllerMethodDiscovered

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done here 775a81b

Turini added a commit that referenced this pull request Nov 14, 2013
@Turini Turini merged commit 9bdb2f3 into DownloadObservingInsteadOfIntercepting Nov 14, 2013
@Turini Turini deleted the UploadObservingInsteadOfIntercepting branch November 14, 2013 11:00
@Turini Turini added this to the 4.0.0-beta-4 milestone Mar 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants