changing scope of InstantiateObserver #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,7 +36,7 @@ | |||
| * @author Guilherme Silveira | |||
| * @author Rodrigo Turini | |||
| */ | |||
| @ApplicationScoped | |||
| @RequestScoped | |||
There was a problem hiding this comment.
The only way to solve this concurrency problem is really creating an InstantiateObserver
each request? Did you try inject Container on observer method? I'm not sure, but it may work.
There was a problem hiding this comment.
The problem is that you can't have a instance of ControllerInstance, because it can be replaced by another thread between the instantiate and getControllerInstance
There was a problem hiding this comment.
Sure! Now that I realized that InstantiateObserver are not stateless. Ok then, 🍧
mariofts
added a commit
that referenced
this pull request
Dec 11, 2013
changing scope of InstantiateObserver. closes #276
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #276