Checking if bean is a proxy #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| public static <T> Class<?> extractRawType(Class<T> type) { | ||
| return isCDIProxy(type) ? type.getSuperclass() : type; |
There was a problem hiding this comment.
shouldn't we be checking for javassist/cglib proxies as well?
There was a problem hiding this comment.
Since JavassistProxifier is managed class, and this class gets all managed classes, we will get a overflow.
|
⛳ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is the best solution.
When we use redirects like
result.redirectTo(this).coolMethod(), CDI is asked for a instance for a proxy, that throws an exception.Because this is a draft, after your suggestions, I'll write some docs.