changing ServletBasedEnvironment order #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| String contextEnv = context.getInitParameter(ENVIRONMENT_PROPERTY); | ||
| if (contextEnv != null) { | ||
| return contextEnv; | ||
| String systemEnv = System.getenv("VRAPTOR_ENVIRONMENT"); |
There was a problem hiding this comment.
"VRAPTOR_ENV"? as in "RAILS_ENV", "RACK_ENV", etc =)
There was a problem hiding this comment.
VRAPTOR_ENV is simpler and better.
On Fri, Jan 17, 2014 at 11:54 AM, Lucas Cavalcanti <notifications@github.com
wrote:
In
vraptor-core/src/main/java/br/com/caelum/vraptor/environment/ServletBasedEnvironment.java:@@ -35,14 +35,14 @@ public ServletBasedEnvironment(ServletContext context) throws IOException {
}private static String env(ServletContext context) {
String contextEnv = context.getInitParameter(ENVIRONMENT_PROPERTY);if (contextEnv != null) {return contextEnv;String systemEnv = System.getenv("VRAPTOR_ENVIRONMENT");"VRAPTOR_ENV"? as in "RAILS_ENV", "RACK_ENV", etc =)
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/319/files#r8967236
.
Rafael Ponte
http://www.triadworks.com.br
There was a problem hiding this comment.
cool :) done here ac82df7
|
🚢 |
Turini
added a commit
that referenced
this pull request
Jan 18, 2014
changing ServletBasedEnvironment order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed here 40a8876#commitcomment-5098886