-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes caelum/vraptor#581. Only instantiate objects with same type #355
Conversation
Affects vraptor3. If this pull request will accepted, we need to replicate the changes. |
List<Message> errors = new ArrayList<Message>(); | ||
Object[] out = provider.getParametersFor(method, errors); | ||
|
||
assertThat(out[0], not(is(result))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is(not(result))
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, because Result
is a vraptor object that we can't get. We want to get only parameters, not vraptor objects. This is the propose of the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is(not(result))
reads better than not(is(result))
;) 🍂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done by a7990e8
🚌 |
OtherResource.class.getDeclaredMethod("logic", String.class)); | ||
|
||
List<Message> errors = new ArrayList<Message>(); | ||
Object[] out = provider.getParametersFor(method, errors); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed the test because I think that we need to check if IOGI got the right parameter too. @lucascs right?
Closes caelum/vraptor#581. Only instantiate objects with same type
@lucascs Thank you for review my code. |
Closes caelum/vraptor#581.