Disconnecting Parameter from AnnotatedElement due compilation errors under JDK8 #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since you removed the interface, please check which of these methods are not being used anywhere and remove them. |
|
Why remove? The methods can be useful. The proposal for this class is keep compatibilty with |
|
Because nothing is using it => less code to maintain. Besides, it's very easy to add these methods if needed. |
|
All methods are used, as my Eclipse alerts me. |
|
so 🚌 |
garcia-jj
added a commit
that referenced
this pull request
Feb 17, 2014
Disconnecting Parameter from AnnotatedElement due compilation errors under JDK8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With inheritance we need to override more methods if using JDK 8, but this methods don't exists in JDK 7. So with this change this class works fine on both environments.