Check for tempdir once #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,12 +51,14 @@ public long getSizeLimit() { | |||
|
|
|||
| @Override | |||
| public File getDirectory() { | |||
| Path tmp = getTemporaryDirectory(); | |||
There was a problem hiding this comment.
We really need to use lock in this block avoiding access by another thread? The only issue if many thread access in same time is check for tmpdir twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this time we create a temp file on each time that upload was requested. For applications that have a lot of upload requests, application may stay slow.
So with this change we create a temp file once, and store the reference in a attribute.