-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
:polemico: Simplifying Events #436
Conversation
…MethodInfo produces and the ControllerMethod is the event itself
@@ -10,4 +11,14 @@ | |||
*/ | |||
public class NewRequest { | |||
|
|||
private final RequestInfo request; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change the field to requestInfo
(and getRequestInfo
, sure =)
Just to be clear that its not the real request. What do you think?
besides the minor on field name, everthink seems fair enough to me. 👍 |
which dependency? |
:thanks_god: I love it |
@Turini I don't know which dependency, I get a StackOverflow if RequestObserverHandler receives a |
I'm having a different problem changing it, because |
I'll try again tonight and see if I come up with some good solution. |
NewRequest
now holds the correspondingRequestInfo
ControllerMethod
turned into an event, so we can removeControllerMethodDiscovered
.@Observes ControllerMethod
reads just fine, IMHO.MethodInfo
now observes changes inControllerMethod
and@Produces
it, so we can removeControllerMethodFactory
.I tried to remove
NewRequest
also, but there is some weird dependency.WANT: remove CDIProvider.
What do you think?