:polemico: Removing RequestInfo #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odNotAllowedHandler
| @@ -81,6 +82,15 @@ public void setParameter(String key, String... value) { | |||
| logger.debug("Setting {} with {}", key, value); | |||
| extraParameters.put(key, value); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This changes servlets behaviour. Have you tested in Wildfly and another servlet container?
There was a problem hiding this comment.
No it doesn't.
the HSRequest method is getRequestURI ;)
maybe this is not the best name...
|
I love when we have a pull request that removes a lot of code. But the best of this pr it's merge some factories. Sounds like good for me. Less code keeps vraptor more simple and easily to maintain. |
+1. It was a nice change |
lucascs
added a commit
that referenced
this pull request
Mar 20, 2014
:polemico: Removing RequestInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RequestInfois also a VRaptor 3 inheritance that doesn't make sense for VRaptor 4.It's role was to implement proper scopes for the DI providers. Since CDI handles the scopes, this class is not that important anymore.
So I removed all direct references to
RequestInfoand turned it intoNewRequestevent.