removing all ignored tests #514
Conversation
|
I agree. But I think that it's best to wait two or more votes from other 🔥 Connected with Motocast™ |
| @@ -224,19 +223,4 @@ public void setY(Integer y) { | |||
| this.y = y; | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| @Ignore("Should it work someday?") | |||
There was a problem hiding this comment.
Why this test fails? I guess it should work.
There was a problem hiding this comment.
I'm really not sure about that, but I think it not works. The test results:
java.lang.IllegalArgumentException: Parameters paths are invalid: [abc.y] for method public void br.com.caelum.vraptor.http.route.RouteBuilderTest$Generic.gee(java.lang.Object)
at br.com.caelum.vraptor.http.route.DefaultTypeFinder.getParameterTypes(DefaultTypeFinder.java:66)
the method gee receives T as argument. Should it work?
There was a problem hiding this comment.
If Specific.class binds T to Bolinha, why not?
There was a problem hiding this comment.
So do you have any idea why this test don't work?
Take a look on DefaultTypeFinder.getParameterTypes(...),
it is trying to call method getY on Object for this test case...
So or the test is wrong or it really dont should to work :)
There was a problem hiding this comment.
No idea. What is the failure when you remove the @Ignore?
There was a problem hiding this comment.
here is the full stack trace :) https://gist.github.com/Turini/11199258
There was a problem hiding this comment.
Caused by: java.lang.NullPointerException
at br.com.caelum.vraptor.http.route.DefaultTypeFinder.getParameterTypes(DefaultTypeFinder.java:64)
easy fix ;)
There was a problem hiding this comment.
not so easy... see the follow line (the NPE line):
type = new Mirror().on(type).reflect()
.method("get" + upperFirst(item)).withoutArgs().getReturnType();as I said, it's trying to call getY() from Object here =P
There was a problem hiding this comment.
I don't have time to do this now, but I'd at least leave this test ignored.
No description provided.