Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making it possible to set properties of a convertable #558

Merged
merged 2 commits into from
May 27, 2014

Conversation

lucascs
Copy link
Member

@lucascs lucascs commented May 27, 2014

There is a bug today (https://groups.google.com/d/msg/caelum-vraptor/oDf8LmNKHuE/b_8cDtuB10kJ) in which you are not able to set parameter for a type that has a converter set up.

The bug only happens when there are multiple properties to be set.

@garcia-jj
Copy link
Member

Yeah. Sounds like good. But Travis dislike your commit.

[ERROR] /home/travis/build/caelum/vraptor4/vraptor-core/src/test/java/br/com/caelum/vraptor/http/iogi/IogiParametersProviderTest.java:[199,63] cannot find symbol

@lucascs
Copy link
Member Author

lucascs commented May 27, 2014

now it will ;)

@Turini
Copy link
Member

Turini commented May 27, 2014

now it looks fine, but the user said that it does not work yet =(
https://groups.google.com/forum/#!msg/caelum-vraptor/oDf8LmNKHuE/b_8cDtuB10kJ

@vitornp
Copy link
Contributor

vitornp commented May 27, 2014

Created repo https://github.com/vitornp/vraptor-poc, with test

@vitornp
Copy link
Contributor

vitornp commented May 27, 2014

Sorry, I was returning null in converter. Bug fix 👍

Thank very much

@Turini
Copy link
Member

Turini commented May 27, 2014

🍴

@vitornp
Copy link
Contributor

vitornp commented May 27, 2014

@Turini I will create a PR with example in documentation

@Turini
Copy link
Member

Turini commented May 27, 2014

@vitornp, It will be very welcome :) thanks

lucascs added a commit that referenced this pull request May 27, 2014
Making it possible to set properties of a convertable
@lucascs lucascs merged commit f633bf0 into master May 27, 2014
@lucascs lucascs deleted the lc-convertables branch May 27, 2014 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants