Adding the default constructor for MockSerializationResult. #607
Conversation
| @@ -48,6 +53,13 @@ public XStreamBuilderImpl(XStreamConverters converters, TypeNameExtractor extrac | |||
| this.extractor = extractor; | |||
| } | |||
|
|
|||
| public static XStreamBuilder cleanInstance(Converter...converters) { | |||
There was a problem hiding this comment.
where are you using it? why do we need this method?
There was a problem hiding this comment.
It's used on default constructor...
Because this method is on XStreamBuilderFactory that is a class of test folder.
So when we create the vraptor jar, test folder is discarted and I can't use it.
There was a problem hiding this comment.
so change XStreamBuilderFactory to be @Deprecated and make it delegate to this method.
There was a problem hiding this comment.
Why not just to remove the XStreamBuilderFactor?
(since it's a src/test class, it will not break compatibility)
There was a problem hiding this comment.
I did this in the other PR, but @lucascs cited:
"Rollback this change. VRaptor is released, we cannot simply remove a class without bumping the major release version."
There was a problem hiding this comment.
this is an src/test util class... no problems removing it, right @lucascs?
|
Done. What do you think ? @Turini @garcia-jj |
|
I agree that we don't need the I'll wait for the best solution, if we remove the |
|
What do you think ? @Turini @lucascs @garcia-jj Remove the class |
|
Deprecated with a note what's the new method, and that will be dropped in |
|
why we can't remove it? this is just a |
|
Ow, right. Classes under test folder isn't exported to jar. You are right. I've changed my mind. Remove it. |
|
So, may I remove it ? |
|
please |
|
Done. |
|
Ready to merge? |
|
⛵ |
|
I never know the meaning of 🐑 ⛵ ! rsrs 😕 |
|
@renanigt Me, Lucas and Turini (and other devs) have commiter permission on vraptor repository. But instead of simple commit into master, we commit any change in a branch and send a pull request. With this, other devs can review our code to suggest improvements. When all reviews are done and the code is ready to merge, we use a random emoji to say "Yeah, you can merge". 🐑 emoji have the same sound that ship, that mean "ship it, send your code". |
…tionResult Adding the default constructor for MockSerializationResult.
|
Thank you. |
|
Thanks for the explanation. rsrs @garcia-jj Thanks for the learning here with you ( @Turini @garcia-jj @lucascs ). |
I change
MockSerializationResultTestto use the default constructor. May be ?