Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring vraptor-musicjungle's tests #614

Merged
merged 4 commits into from
Jun 19, 2014

Conversation

renanigt
Copy link
Contributor

Refactoring to use the default constructor of MockSerializationResult and removing the unnecessary class XStreamBuilderFactoring to use XStreamBuilderImpl in vraptor-musicjungle's test.

@Turini
Copy link
Member

Turini commented Jun 19, 2014

please, can you provide a better tittle and description?
PR's title goes to changelog, so it should explain better it's intention.

@renanigt
Copy link
Contributor Author

Sorry, I didn't know about this.

@renanigt renanigt changed the title Fixing music jungle Default constructor of MockSerializationResult on vraptor-musicjungle's tests Jun 19, 2014
@renanigt
Copy link
Contributor Author

And now, what do you think ?

@renanigt renanigt changed the title Default constructor of MockSerializationResult on vraptor-musicjungle's tests Refactoring vraptor-musicjungle's tests Jun 19, 2014
@garcia-jj
Copy link
Member

Great. Thank you

garcia-jj added a commit that referenced this pull request Jun 19, 2014
Refactoring vraptor-musicjungle's tests
@garcia-jj garcia-jj merged commit 36c121d into caelum:master Jun 19, 2014
@renanigt renanigt deleted the fixingMusicJungle branch July 2, 2014 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants