Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docs about indented JSON/XML #644

Merged
merged 4 commits into from
Jun 28, 2014
Merged

Adding docs about indented JSON/XML #644

merged 4 commits into from
Jun 28, 2014

Conversation

garcia-jj
Copy link
Member

Related to #612.

  • At this time there are no docs about view and ajax in english.


~~~
#!java
result.use(json()).indented().from(carro).serialize(); //=> {\n 'carro': {\n 'cor': 'azul'\n }\n}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to improve the UX (mainly on mobile version), can you remove
the code comment and add as simple text? something like this:

result.use(json()).indented().from(carro).serialize();

dessa forma o resultado seria:

{
    'carro': 
    {
       'cor': 'azul'
    }
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with 8d4d7d2

@Turini
Copy link
Member

Turini commented Jun 28, 2014

before change the comment, 🚢


Dessa forma o resultado seria:

#!javascript
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong format here, missing ~~~

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Added with 2c85e02

@Turini
Copy link
Member

Turini commented Jun 28, 2014

👍

garcia-jj added a commit that referenced this pull request Jun 28, 2014
Adding docs about indented JSON/XML
@garcia-jj garcia-jj merged commit fd968f5 into master Jun 28, 2014
@garcia-jj garcia-jj deleted the ot-indentedviewdocs branch June 28, 2014 19:44
@Turini Turini mentioned this pull request Jun 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants