checking if beandescriptor is null

[asouza]

If the parameter does not have any constraint, the returned BeanDescriptor is null...

[Turini]

can you add an unit test catching this case?

[garcia-jj]

This behavior is too strange. Javadocs are not clear if getConstraintsForClass returns null. But I think that not because this method returns the class descriptor, not method descriptor. So it's to strange to return null.

I did some tests and getConstraintsForClass never returns null. Look my code below:

    public void m0() { }

    public void m1(String name) { }

    public void m2(@NotNull String name) { }

    @Test
    public void foo() {
        Validator validator = Validation.buildDefaultValidatorFactory().getValidator();
        BeanDescriptor bean = validator.getConstraintsForClass(AppTest.class);
        System.out.println("bean " + bean);

        System.out.println("m0 " + bean.getConstraintsForMethod("m0"));
        System.out.println("m1 " + bean.getConstraintsForMethod("m1", String.class));
        System.out.println("m2 " + bean.getConstraintsForMethod("m2", String.class));
    }

Prints:

bean BeanDescriptorImpl{class='AppTest'}
m0 null
m1 null
m2 ExecutableDescriptorImpl{name='m2'}

For me, there are no problem with this null check, but I don't think that this scenario will happen.

[asouza]

You are right, Otavio... I could not reproduce this scenario in the unit tests... But when I run the integration tests in vraptor-test, the problem always happens :(. My guess is that a problem with proxies or any other thing that we are not being able to see.

[Turini]

typo: Constraing

[Turini]

fixed here c1bb8d5

[Turini]

I think its good to merge... this is a simple null check, if helps on plugin 👍

[garcia-jj]

Yes, good to merge if this can help vraptor test. But be carefully because
null can mask another error in vraptor-test.

[garcia-jj]

🐑

[Turini]

merged thanks!

[garcia-jj]

Unused import CdiProxies.

[Turini]

removed here b01599d