Fixing instability with deserializing and instantiator order

[Turini]

Closes #668

[garcia-jj]

I dislike this inline if. What you think if you extract to method names hasConstraint and add this check in existent if?

[Turini]

done, what about now?

[garcia-jj]

Turini, I really sorry about my typo (my cellphone is too bad). I think in something like:

if (isNotParameterless() && hasNoConsumes())

That means, only extract your method.containsAnnotation(Consumes.class) to a method.

But since you already merged both methods, may we can rename to another name (hasConstraint is a mistake, because we don't have any constraint here).

Suggestions? I'm not good with names. My two dogs know about this :)

[Turini]

no worries, I'll change it tomorrow =)

[lucascs]

arity will never be less than 0 ;)

use == 0

[lucascs]

My only concern about this PR is that we won't support:

@Post("/product/{product.id}")
@Consumes
public void update(Product product) {....}

or

@Post("/product/{product.id}/reviews")
@Consumes
public void add(Review review, Product product) {....}

[rponte]

Not supporting this kind of parameters within url is not a good thing :-T

On Thu, Jul 10, 2014 at 11:24 PM, Lucas Cavalcanti <notifications@github.com

wrote:

My only concern about this PR is that we won't support:

@post("/product/{product.id}")@Consumespublic void update(Product product) {....}

or

@post("/product/{product.id}/reviews")@Consumespublic void add(Review review, Product product) {....}

—
Reply to this email directly or view it on GitHub
#680 (comment).

Rafael Ponte
TriadWorks | Formação Java
http://cursos.triadworks.com.br

[Turini]

yes, this is not nice... I'll write some tests and change the code to cover that

[Turini]

this example provided for @lucascs does not work independent of
observers order or using events or interceptors... and I guess neither in
vr3 it works :) but I'm trying a solution for it anyway... this is important.

[defaultbr]

its different from VRaptor 3? i've never used @consumes in VRAptor 3, but i heard that it work perfectly using VRaptor 3, so maybe can use the same idea? or cant because the CDI?

[Turini]

Done! Now the code works fine independent of execution
order and works with path parameters, just like:

@Consumes("application/json")
@Path("/url/{id}")
public void test(Long id, Curso curso) {
    System.out.println("ID "+id);
    System.out.println("JSON "+ curso);
    result.forwardTo(this).index();
}

Or even:

@Consumes("application/json")
@Path("/url/{curso.id}/{curso.nome}")
public void test2(Curso curso, Curso curso2) {
    System.out.println("URL "+curso);
    System.out.println("JSON "+ curso2);
    result.forwardTo(this).index();
}

[Turini]

ẁhat do you think?

[garcia-jj]

good name

[garcia-jj]

sounds ⛵ to me

[lucascs]

🚢, but it doesn't support:

POST /cursos/1234
{"curso": {"nome": "FJ-21"}}

@Post("/cursos/{curso.id}") @Consumes
public void atualiza(Curso curso) {...}

[lucascs]

But this is another PR.