Open Linker for extension #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,6 +45,23 @@ public Linker(ServletContext context, Router router, Class<?> controller, String | |||
| } | |||
|
|
|||
| protected String getLink() { | |||
| Method method = getMethod(); | |||
| return getContextPath() + router.urlFor(controller, method, getArgs(method)); | |||
There was a problem hiding this comment.
change controller to getController()
|
@lucascs it was used by the I18nLinker, but I changed to return the router. |
|
@dtelaroli if we pass the router on the constructor manually, we don't need to have this |
|
@lucascs the your comment was pointed on the constructor code, I thought that you have mentioned the properties, so, I will remove the getController too. |
|
it was indeed to remove unnecessary getters =) |
| return getContextPath() + router.urlFor(controller, method, getArgs(method)); | ||
| } | ||
|
|
||
| protected String getContextPath() { |
There was a problem hiding this comment.
I'd rename it to getPrefix(). ContextPath is the implementation.
|
thanks @dtelaroli! It'll be released at RC2 version (asap) |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the #702 as dependency on the caelum/vraptor-i18n#32