Adding support for Download builder #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. 👍 |
|
@guilhermesilveira As you suggested :). Thank you. |
| * .build(); | ||
| * </code> | ||
| */ | ||
| public static InputStreamDownloadBuilder of(InputStream input) { |
There was a problem hiding this comment.
I don't like this kind of javadoc. This is hard to maintain and kinda heavy.
I think a succinct description would be enough here (and keep our docs
symmetry)... we can share this full explained code on VRaptor's site docs.
| public class FileDownloadTest { | ||
|
|
||
| @Rule | ||
| public ExpectedException thrown = ExpectedException.none(); |
There was a problem hiding this comment.
This rule was a @csokol suggestion, and I think we can use from now, because we can capture messages and more. Using @Test(expected) we can't take full controll of exception thrown.
|
🐑 |
garcia-jj
added a commit
that referenced
this pull request
Sep 12, 2014
Adding support for Download builder
| } | ||
|
|
||
| public static abstract class AbstractDownloadBuilder<T> { | ||
| protected String fileName; |
There was a problem hiding this comment.
Devs, what you think to reducing visibility of this class, since only builder can see this? There is no reason to expose this class to the world.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #789. As discussed in dev mailing list and under issue #789.
I don't know if we use all builder subclasses as inner classes or external classes. Ideas?
After all comments, I can write some docs and improve tests for bytearray and inputstream.