-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trying to fix Travis instability #809
Conversation
@renanigt can you test it in your environment? just run |
@Turini, before this commit I got many errors, but now I got just 2 errors:
|
please, can you create a simple test and run this code? System.out.println(junit.runner.Version.id()); |
@Turini, the output was |
Running into eclipse, the error doesn't occurs. |
@Turini Can you force Travis build many times (something like 10 times) to make sure that all tests pass ok? I think that Travis are more important to solve than other environments because Travis errors bothering us, and hidden some test failures when we commit something. Another point: whats the Maven versions used by Travis? Have you the same version? Because can be a Maven issue. |
I agree that Travis is most important than other enviroments, but IMHO we need to continue trying to fix it in all enviroment. If in some enviroments the tests doesn't pass, it discourages users to send a PR. If pass only in Travis, we need to send a PR to know if tests are passing or not. |
Hi guys, sorry my delay (really busy week!). Comments inline:
Already done, and its working always on Travis in this branch. I'll merge it
Yes, I've built an aws ec2 instance to reproduce travis environment... |
trying to fix Travis instability
@renanigt My point is to solve Trais too soon as possible, and if tests are fail for some users, we can fix later. |
True @garcia-jj ! Thanks. 😃 |
I did tests locally before push, so my pull requests are fine to merge. But if you prefer I can rebase my branches from master. |
no need :) we can see how travis will react in the next PR's |
Ohh, yeahhh. Now Travis are smiling to us. ☕ Green lights back. |
great! |
using CDI.current() and providing a scope for Context