Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying to fix Travis instability #809

Merged
merged 2 commits into from
Sep 23, 2014
Merged

Conversation

Turini
Copy link
Member

@Turini Turini commented Sep 22, 2014

using CDI.current() and providing a scope for Context

@Turini
Copy link
Member Author

Turini commented Sep 22, 2014

@renanigt can you test it in your environment? just run mvn test

@renanigt
Copy link
Contributor

@Turini, before this commit I got many errors, but now I got just 2 errors:

Tests in error: 
  shouldNotRunVRaptorStackIfVRaptorRequestStartedEventNotFired(br.com.caelum.vraptor.ioc.RequestStartedFactoryTest): WELD-001303: No active contexts for scope type javax.enterprise.context.RequestScoped
  shouldRunVRaptorStackIfVRaptorRequestStartedEventIsFired(br.com.caelum.vraptor.ioc.RequestStartedFactoryTest): WELD-001303: No active contexts for scope type javax.enterprise.context.RequestScoped

@Turini
Copy link
Member Author

Turini commented Sep 22, 2014

please, can you create a simple test and run this code?

System.out.println(junit.runner.Version.id());

@renanigt
Copy link
Contributor

@Turini, the output was 4.11.

@renanigt
Copy link
Contributor

Running into eclipse, the error doesn't occurs.

@garcia-jj
Copy link
Member

@Turini Can you force Travis build many times (something like 10 times) to make sure that all tests pass ok? I think that Travis are more important to solve than other environments because Travis errors bothering us, and hidden some test failures when we commit something.

Another point: whats the Maven versions used by Travis? Have you the same version? Because can be a Maven issue.

@renanigt
Copy link
Contributor

I agree that Travis is most important than other enviroments, but IMHO we need to continue trying to fix it in all enviroment.

If in some enviroments the tests doesn't pass, it discourages users to send a PR.

If pass only in Travis, we need to send a PR to know if tests are passing or not.

@Turini
Copy link
Member Author

Turini commented Sep 23, 2014

Hi guys, sorry my delay (really busy week!). Comments inline:

Can you force Travis build many times (something like 10 times) to
make sure that all tests pass ok?

Already done, and its working always on Travis in this branch. I'll merge it
to see if master and another branches will work too (without close the issue)

Another point: whats the Maven versions used by Travis? Have you the
same version? Because can be a Maven issue.

Yes, I've built an aws ec2 instance to reproduce travis environment...

Turini added a commit that referenced this pull request Sep 23, 2014
@Turini Turini merged commit 3678824 into master Sep 23, 2014
@Turini Turini deleted the restartingWeldContainerEachTest branch September 23, 2014 13:56
@garcia-jj
Copy link
Member

@renanigt My point is to solve Trais too soon as possible, and if tests are fail for some users, we can fix later.

@renanigt
Copy link
Contributor

True @garcia-jj !

Thanks. 😃

@Turini
Copy link
Member Author

Turini commented Sep 23, 2014

guys, master is now green on travis!
(the other current PR's isn't... because does not have this code).

screen shot 2014-09-23 at 11 28 15

@garcia-jj
Copy link
Member

I did tests locally before push, so my pull requests are fine to merge. But if you prefer I can rebase my branches from master.

@Turini
Copy link
Member Author

Turini commented Sep 23, 2014

no need :) we can see how travis will react in the next PR's

@garcia-jj
Copy link
Member

Ohh, yeahhh. Now Travis are smiling to us. ☕ Green lights back.

@Turini
Copy link
Member Author

Turini commented Sep 23, 2014

great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants