Iogi tests refactoring to make code clean #820
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #817
With this pull request I did a small refactor to improved code readability, reducing complexity to allow us to keep maintainability too easy.
ParametersProviderTest
was merged withIogiParametersProviderTest
. In the past, when we had OGNL and Iogi living togheter, this class was useful. But from now this class is unnecessary, and keep the code hard to understand, because some code are splited in two places.Some code are unnecessary after new
ParameterValue
was improved. So a lot of lines are dropped. Some pieces of code are changed to reduce complexity like extracting repeated code to methods, instantiating objects only when need, and a bit more.