Update header.html #959
Update header.html #959
Conversation
Correcting the english version link to Google Groups. Notive that the english version had another behavior, but this was proposed in the user list (https://groups.google.com/forum/#!topic/caelum-vraptor/kfYMTMxKoUk), once the most used list is caelum-vraptor.
Update header.html
| @@ -9,7 +9,7 @@ <h1 class="logo"><a class="logo-link" href="/<%=path%>"> | |||
| <div class="header-links"> | |||
| <ul class="community"> | |||
|
|
|||
| <li><a href="https://groups.google.com/forum/<%=path == 'en' ? '?hl=en#!forum/vraptor4' : '#!forum/caelum-vraptor'%>" target="_blank">Google Groups</a></li> | |||
| <li><a href="https://groups.google.com/forum/#!forum/caelum-vraptor>" target="_blank">Google Groups</a></li> | |||
There was a problem hiding this comment.
Hi @danilomunoz, thanks in advance for sending the pull request.
There is distinct lists for EN and PT_BR languages, as you can see:
https://groups.google.com/forum/#!forum/caelum-vraptor-en
https://groups.google.com/forum/#!forum/caelum-vraptor
Thinking on that, we can't use caelum-vraptor group for both. it'd
be more appropriate to do something like that:
/#!forum/caelum-vraptor<%= path == 'en' ? '-en' : ' ' %>
What do you think? Could you please update your PR? Thanks again
Supporting english version
| @@ -9,7 +9,7 @@ <h1 class="logo"><a class="logo-link" href="/<%=path%>"> | |||
| <div class="header-links"> | |||
| <ul class="community"> | |||
|
|
|||
| <li><a href="https://groups.google.com/forum/<%=path == 'en' ? '?hl=en#!forum/vraptor4' : '#!forum/caelum-vraptor'%>" target="_blank">Google Groups</a></li> | |||
| <li><a href="https://groups.google.com/forum//#!forum/caelum-vraptor<%= path == 'en' ? '-en' : '' %>>" target="_blank">Google Groups</a></li> | |||
There was a problem hiding this comment.
@danilomunoz thank you for changing this, but looks like it has an extra
slash and greater-than sign. This is how the resulted URL is looking like:
and this is how it should look like:
Sorry for my fault. Corrected.
|
Thank you for this contribution, @danilomunoz. |
|
I thank you @Turini |
|
just updating, it's deployed! :) |
Correcting the english version link to Google Groups. Notive that the english version had another behavior, but this was proposed in the user list (https://groups.google.com/forum/#!topic/caelum-vraptor/kfYMTMxKoUk), once the most used list is caelum-vraptor.