Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small optimizations #97

Merged
merged 5 commits into from
Sep 22, 2013
Merged

Small optimizations #97

merged 5 commits into from
Sep 22, 2013

Conversation

Turini
Copy link
Member

@Turini Turini commented Sep 21, 2013

No description provided.

@lucascs
Copy link
Member

lucascs commented Sep 21, 2013

What is the optimization? I can only see a component extraction.

@Turini
Copy link
Member Author

Turini commented Sep 22, 2013

Now we use only one instance of InterceptorMethodParametersResolver (app scoped) instead
of 1 for each interceptor for each request (it helps a little when testing a lot of requests because
decreases number of instances in memory and frequency of GC activity).

@lucascs
Copy link
Member

lucascs commented Sep 22, 2013

It's just to avoid generic PR titles ;) thanks for the explanation.
Em 22/09/2013 07:34, "Rodrigo Turini" notifications@github.com escreveu:

Now we use only one instance of InterceptorMethodParametersResolver (app
scoped) instead
of 1 for each interceptor for each request (it helps a little when testing
a lot of requests because
decreases number of instances in memory and frequency of GC activity).


Reply to this email directly or view it on GitHubhttps://github.com//pull/97#issuecomment-24879669
.

Turini added a commit that referenced this pull request Sep 22, 2013
InterceptorMethodParametersResolver and DefaultEncodingHandler are now managed and app scoped
@Turini Turini merged commit 578e97d into master Sep 22, 2013
@Turini Turini deleted the smallOptimizations branch September 22, 2013 15:05
@Turini
Copy link
Member Author

Turini commented Sep 22, 2013

Nice, I did a better description on merge message :)

@Turini Turini added this to the 4.0.0-beta-1 milestone Mar 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants