Allowing to override custom Gson Date pattern #998
Conversation
Turini
changed the title
| @@ -41,6 +41,16 @@ | |||
|
|
|||
| If you are using JDK 8, you can use the new `java.time` API available using [vraptor-java8](/en/docs/plugins#vraptor-java-8) plugin. | |||
|
|
|||
| You can also customize the Date pattern by implementing your own CustomDateGsonConverter and overriding the method `getPattern()`: | |||
There was a problem hiding this comment.
What do you think about moving this doc to the end of this page, using the follow title?
#Overriding custom JSON and XML converters
It sounds better to me, because only in that point we tell how to override VRaptor beans.
There was a problem hiding this comment.
Sounds great! Just moved it to the end of the file
|
@Philippe2201 That sounds great! I left a simple suggestion, what do you think? |
|
And about Calendar?
|
| @@ -44,7 +44,7 @@ | |||
| private final SimpleDateFormat iso8601Format; | |||
|
|
|||
| public DateGsonConverter() { | |||
| this.iso8601Format = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssZ"); | |||
| this.iso8601Format = new SimpleDateFormat(getPattern()); | |||
There was a problem hiding this comment.
Since getPattern defines the new format, this variable should renamed. My suggestion is format.
|
All suggestions done, but what did you suggest about Calendar? |
| @@ -41,25 +41,29 @@ | |||
| @Dependent | |||
| public class DateGsonConverter implements JsonDeserializer<Date>, JsonSerializer<Date>{ | |||
|
|
|||
| private final SimpleDateFormat iso8601Format; | |||
| private final SimpleDateFormat format; | |||
There was a problem hiding this comment.
Drop this instance variable and [...]
|
@Philippe2201 |
|
This pull request will be very useful. Thank you @Philippe2201. |
|
Great! Just pushed the last modifications |
|
@Philippe2201 could you update your docs, changing the return to DateFormat? |
|
🚀 |
|
@Turini yes! just did it |
|
thank you so much, merging here |
Allowing to override custom Gson Date pattern
Closes #931