client_ssl_auth: Fix for filter closing connection without reason (en…

…voyproxy#35034) Fixes envoyproxy#34997 Signed-off-by: Arul Thileeban Sagayam <arul.thilee@gmail.com> Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
cainelli · Jul 5, 2024 · a322403 · a322403
1 parent c6eea9b
commit a322403
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/contrib/client_ssl_auth/filters/network/source/client_ssl_auth.cc b/contrib/client_ssl_auth/filters/network/source/client_ssl_auth.cc
@@ -130,7 +130,8 @@ void ClientSslAuthFilter::onEvent(Network::ConnectionEvent event) {
         StreamInfo::CoreResponseFlag::UpstreamProtocolError);
     read_callbacks_->connection().streamInfo().setResponseCodeDetails(AuthDigestNoMatch);
     config_->stats().auth_digest_no_match_.inc();
-    read_callbacks_->connection().close(Network::ConnectionCloseType::NoFlush);
+    read_callbacks_->connection().close(Network::ConnectionCloseType::NoFlush,
+                                        "auth_digest_no_match");
     return;
   }
 

diff --git a/contrib/client_ssl_auth/filters/network/test/client_ssl_auth_test.cc b/contrib/client_ssl_auth/filters/network/test/client_ssl_auth_test.cc
@@ -167,7 +167,8 @@ TEST_F(ClientSslAuthFilterTest, Ssl) {
               setResponseFlag(StreamInfo::CoreResponseFlag::UpstreamProtocolError));
   EXPECT_CALL(filter_callbacks_.connection_.stream_info_,
               setResponseCodeDetails("auth_digest_no_match"));
-  EXPECT_CALL(filter_callbacks_.connection_, close(Network::ConnectionCloseType::NoFlush));
+  EXPECT_CALL(filter_callbacks_.connection_,
+              close(Network::ConnectionCloseType::NoFlush, "auth_digest_no_match"));
   EXPECT_EQ(Network::FilterStatus::StopIteration, instance_->onNewConnection());
   filter_callbacks_.connection_.raiseEvent(Network::ConnectionEvent::Connected);
   filter_callbacks_.connection_.raiseEvent(Network::ConnectionEvent::RemoteClose);