Improved accessibility of text style props for customized toast messages #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @EmreKarslan, thanks for your contribution! However, I suggest adding |
|
@EmreKarslan when you can, please check the failing test |
|
Hi @calintamas, it seems the problem stems from mergeIfDefined. I was passing null as the default value. I think I fixed it when I added text1 and text2 styles as defaults. |
|
@EmreKarslan the expected value needs to be updated in the test case. I suggest keeping the defaults to |
…le in the options
|
thank you, released in 2.1.9 |
calintamas
pushed a commit
to wouterds/react-native-toast-message
that referenced
this pull request
Dec 15, 2023
* fix: availability of text1 and text2 style props * chore(types): move text1Style and text2Style to ToastOptions * refactor: Update test case to include missing text1Style and text2Style in the options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made modifications to enhance the accessibility of text style props in React Native Toast Message library. The existing implementation caused issues when customizing toast messages in my application, particularly with regard to the text style. To address this, I adjusted the code to ensure that the text-style props are easily accessible and can be modified according to specific requirements. These changes resolve the issues I encountered and provide a smoother experience when customizing toast messages.
closes #478