Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fab.group): subitems are accessibility focusable when collapsed #4498

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

personalizedrefrigerator

Motivation

Goal: Improve the accessibility of the FAB.Group component by preventing hidden items from being focused.

Related issue

Previously, FAB.Group items were accessibility focusable even when the menu was collapsed:

before.mp4

Note: This only fixes the issue on Android and iOS. A similar issue persists on web.

Test plan

iOS:

  1. Open the example app in the simulator.
  2. Open the "Floating Action Button" example.
  3. Enable VoiceOver system-wide.
  4. Move VoiceOver focus to the simulator.
  5. Move VoiceOver focus to the next item. Verify that the item is not a hidden member of the FAB.Group.
  6. Repeat step 5 until focus is on the "+" FAB.
  7. Activate the current item.
  8. Move VoiceOver focus to the next item until the floating calendar FAB has focus. Verify that the menu items ("unlabeled", "star", "email", "remind", toggle on long press") each are focusable.
    • Note: VoiceOver will focus items not in the FAB.Group menu during this step. This is a separate issue.

Screen recording:

after.mp4

Note: The above screen recording also uses Expo SDK 51 (I was having trouble deploying the example with SDK 48).

@callstack-bot
Copy link

callstack-bot commented Sep 17, 2024

Hey @personalizedrefrigerator, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants