Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DerefMut for Utf8PathBuf #58

Closed
wants to merge 1 commit into from
Closed

Implement DerefMut for Utf8PathBuf #58

wants to merge 1 commit into from

Conversation

ldm0
Copy link

@ldm0 ldm0 commented Mar 9, 2023

fixes #57

@sunshowers
Copy link
Collaborator

Thanks for the submission! Unfortunately I don't think this is correct: you can't have a &T at any step and then turn it into a &mut T.

I'll try fixing this, and also adding a miri check to ensure that it is correct.

@sunshowers
Copy link
Collaborator

Going to close this in favor of #59. Thanks again!

@sunshowers sunshowers closed this Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement DerefMut for Utf8PathBuf
2 participants
@ldm0 @sunshowers