-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust gmf-drawfeature CSS styling #1024
Conversation
@pgiraud If you want to have a quick "look and feel" go take a look at the live demo (see in the description above). You'll see how it looks with icons instead of text. |
{{'Delete' | translate}} | ||
</button> | ||
</div> | ||
|
||
<div class="gmf-eol"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds like a hack to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you suggest as alternative ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with this first. But we should replace this in the future. At least we'll try.
81df974
to
7bd2dd9
Compare
@pgiraud Would you please do an official review of this task ? If everything is to your likings, then we could merge this. Thanks. |
Is it possible/easy to add tooltips to the draw buttons? |
Sorry for my misunderstanding, but is the |
@@ -8,6 +8,7 @@ | |||
<meta name="mobile-web-app-capable" content="yes"> | |||
<link rel="stylesheet" href="../../../node_modules/openlayers/css/ol.css" type="text/css"> | |||
<link rel="stylesheet" href="../../../node_modules/bootstrap/dist/css/bootstrap.css" type="text/css"> | |||
<link rel="stylesheet" href="../../../node_modules/font-awesome/css/font-awesome.css" type="text/css"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird indentation.
Here's what I meant in my previous comment: |
I thought I already sent a comment about this, but can't find it. |
Thanks for the review. I'll apply the required changes one by one, but I may need clarifications for some. I'll contact you if needed. |
7bd2dd9
to
4b23f48
Compare
Corrections made. Live demo up to date. Ready for merge. |
4b23f48
to
cab15fc
Compare
Looks good to me. |
Work in progress for the CSS styling of the
gmf-drawfeature
directive.Todo
The official icons won't be used as part of this PR. We'll wait the integration to the Desktop application to do so.
Live demo