Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ngeo-exportfeatures directive, used in gmf-drawfeature #1044

Merged
merged 2 commits into from
Apr 20, 2016

Conversation

adube
Copy link
Contributor

@adube adube commented Apr 19, 2016

This PR introduces the ability to export features that are drawn using the gmf-drawfeature directive.

  • The ngeo.FeatureHelper is responsible of executing the writing of features and download as well.
  • A ngeo-exportfeatures directive is responsible of the UI aspect. It will also be responsible to show a drop-down list if more than one format is defined.
  • The ngeoExportFeatureFormats constant will be responsible of defining in what formats we want the exportation to be supported. Defaults to KML only, if not defined.

Todo

  • support KML export
  • support GPX
  • show drop-down menu if more than one format defined
  • review
  • apply reviewer's corrections
  • reproject when writing features

We won't use template instead of jQuery to build menu items, because the menu has to be a sibling of the button. That can't work with pure Angular.

Live demo

@adube
Copy link
Contributor Author

adube commented Apr 19, 2016

@fgravin Ready for review. See also the example.

@adube adube changed the title (WIP) Add Export in gmf-drawfeature Add ngeo-exportfeatures directive, used in gmf-drawfeature Apr 19, 2016
*/
this.items_ = [];

// build the drop-down menu and items of there's more than one format
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if

@fgravin
Copy link
Member

fgravin commented Apr 20, 2016

Good, see my comments.

@fgravin fgravin merged commit 7a39bdc into camptocamp:master Apr 20, 2016
@adube adube deleted the gmf-drawfeature-export branch April 20, 2016 14:36
@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants