Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add legend block if not required #1054

Merged
merged 2 commits into from
Apr 22, 2016
Merged

Don't add legend block if not required #1054

merged 2 commits into from
Apr 22, 2016

Conversation

pgiraud
Copy link
Contributor

@pgiraud pgiraud commented Apr 21, 2016

We currently add the legend block even if no legend is to be displayed.
This pull request fixes this by using the same ng-if statement as for the legend icon button.

Please review.

@fgravin
Copy link
Member

fgravin commented Apr 21, 2016

I think that extra parenthesis are useless.
:: is just detected as first charcters of a watchable expression, no matter what comes after.

But look goods

@pgiraud
Copy link
Contributor Author

pgiraud commented Apr 22, 2016

Parenthesis removed.
Merging.

@pgiraud pgiraud merged commit 0007ce2 into camptocamp:master Apr 22, 2016
@pgiraud pgiraud deleted the no_legend branch April 22, 2016 14:21
@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Older
Development

Successfully merging this pull request may close these issues.
3 participants
@pgiraud @fgravin @sbrunner