Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore the no_redirect patameter #2647

Merged
merged 1 commit into from
May 19, 2017
Merged

Ignore the no_redirect patameter #2647

merged 1 commit into from
May 19, 2017

Conversation

sbrunner
Copy link
Member

fix #2625

@sbrunner sbrunner added this to the 2.1 milestone May 18, 2017
@sbrunner sbrunner requested a review from fredj May 18, 2017 12:36
fredj
fredj reviewed May 18, 2017
View reviewed changes
src/services/statemanager.js Outdated
@@ -46,10 +46,11 @@ ngeo.StateManager = function(ngeoLocation, ngeoUsedKeyRegexp) {
// state is read from the location URL, or from the local storage if there
// is no state in the location URL.

var paramKeys = ngeoLocation.getParamKeys();
var paramKeys = ngeoLocation.getParamKeys().filter(key) {
return key != 'debug' and key != 'no_redirect';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&& instead of and :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@sbrunner sbrunner merged commit db5e8da into 2.1 May 19, 2017
@sbrunner sbrunner deleted the no-redirect-permalink branch May 19, 2017 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredj fredj fredj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.7
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @fredj