-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to WMS layer in print #2656
Conversation
contribs/gmf/src/directives/print.js
Outdated
var metadata = layer.get('metadata'); | ||
if (metadata) { | ||
var server_name = metadata.ogcServer; | ||
var layer_names = metadata.layers || metadata.printLayers; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
layers and print layers should be inverted :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
contribs/gmf/src/directives/print.js
Outdated
var layer_names = metadata.layers || metadata.printLayers; | ||
if (server_name && layer_names) { | ||
var server = this.ogcServers_[server_name]; | ||
goog.asserts.assert(server); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case we should log an error with production code, the server name isn't verified before ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :-)
fixes #2463