Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix definitions leaking outside of the provide #2949

Merged
merged 2 commits into from
Oct 3, 2017
Merged

Fix definitions leaking outside of the provide #2949

merged 2 commits into from
Oct 3, 2017

Conversation

gberaudo
Copy link
Member

@gberaudo gberaudo commented Oct 3, 2017

All definitions should be local to the provided symbol.
As such, a symbol ngeo.search.toto cannot define Toto in ngeo.search.

@gberaudo
Fix definitions leaking outside of the provide
ee97d53 
All definitions should be local to the provided symbol.
As such, a symbol ngeo.search.toto cannot define Toto in ngeo.search.
@gberaudo
Fix use of ngeo.search.CreateGeoJSONBloodhound
0a4f281
@gberaudo gberaudo requested a review from sbrunner October 3, 2017 13:35
@gberaudo gberaudo merged commit 29c98de into 2.2 Oct 3, 2017
@gberaudo gberaudo deleted the fix_leaking_outside_definitions branch October 3, 2017 14:13
@gberaudo
Copy link
Member Author

gberaudo commented Oct 3, 2017

Thanks

@sbrunner sbrunner modified the milestones: 2.2, 2.2.1 Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@gberaudo @sbrunner