Make lint target reliable #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbrunner, a full lint is around 5s. I expect this change will have no impact on our daily work. |
Previously only the files newer than the timestamp were passed to the linter. Changing the linter config or version did not trigger a lint of all the files. With this commit, all files are linted on changes.
gberaudo
force-pushed
the
reliable_lint_target
branch
from
85cf692
to
b055ed0
Compare
sbrunner
approved these changes
Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only the files newer than the timestamp were passed to the linter.
Changing the linter config or version did not trigger a lint of all the files.
With this commit, all files are linted on changes.