Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix olcs manager constructor #3102

Merged
merged 2 commits into from
Nov 16, 2017
Merged

Fix olcs manager constructor #3102

merged 2 commits into from
Nov 16, 2017

Commits on Nov 15, 2017

  1. Revert "Remove excessively painful eslint rule" 

    This reverts commit cd12f51.
The rule actually catches issues.

Use the following to make both eslint and GCC happy:

```
constructor(...args) {
  super(...args);
}
```
    @gberaudo
    gberaudo committed Nov 15, 2017
    Configuration menu
    Copy the full SHA
    63e156c View commit details
    Browse the repository at this point in the history

  2. Fix calls to constructor in dependent projects

    @gberaudo
    gberaudo committed Nov 15, 2017
    Configuration menu
    Copy the full SHA
    0d0177c View commit details
    Browse the repository at this point in the history