Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gmf mobile keep text in header #4240

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Gmf mobile keep text in header #4240

merged 1 commit into from
Oct 2, 2018

Conversation

julsbreakdown
Copy link
Member

@julsbreakdown julsbreakdown commented Sep 17, 2018 •
edited
Loading

@fredj
Copy link
Member

fredj commented Sep 18, 2018

when opening the left panel and then the "Themes" menu, the two menus (layers and themes) are mixed:
screenshot from 2018-09-18 09-25-15

@fredj
Copy link
Member

fredj commented Sep 18, 2018

And it should be possible to add a title for the left and right panel

@julsbreakdown julsbreakdown changed the title Gmf mobile keep text in header [WIP] Gmf mobile keep text in header Sep 18, 2018
@julsbreakdown
Copy link
Member Author

Ok i will look into it thanks

@julsbreakdown julsbreakdown changed the title [WIP] Gmf mobile keep text in header Gmf mobile keep text in header Sep 24, 2018
fredj
fredj reviewed Sep 24, 2018
View reviewed changes
Copy link
Member

@fredj fredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The closing span are incorrect (missing >)

@julsbreakdown
Copy link
Member Author

-_-'

@julsbreakdown
Merge pull request #4230 from camptocamp/gmf_wrap_icon_img_in_div
e9213f5 
fixes distored images in IE11 by wrapping img in div
@julsbreakdown julsbreakdown merged commit fe993dc into master Oct 2, 2018
@julsbreakdown julsbreakdown deleted the gmf_mobile_keep_text_in_header branch October 2, 2018 11:11
@sbrunner sbrunner added this to the 2.4 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredj fredj fredj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.
3 participants
@julsbreakdown @fredj @sbrunner