612 - GMF draw - Zoom out when required #4292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces the missing behaviour that was explained in 612 for the GMF drawing tool: if a feature is visible but would not fit the extent of the map if we panned, then zoom out.
The NGEO featureHelper
panMapToFeaturehas been renamed tofitMapToFeatureand theopt_zoomoption was removed. It was getting too complex to keep that option, and not really wanted anyway. Therefore, the goal of the method was no longer only to "pan", but to "pan", "zoom" or "fit" depending on the scenario.