-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port offline feature #4348
Port offline feature #4348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No possible regression => no objection :-)
Thanks @sbrunner. Do you know why Travis is red? |
acc5c36
to
59c485a
Compare
it tries to download https://raw.githubusercontent.com/camptocamp/demo_geomapfish/master/geoportal/demo_geoportal/locale/en/LC_MESSAGES/demo_geoportal-client.po |
This pull request should be rebased ... |
- port the ngeo code to ES6 modules; - port the example. Note that the example is actually broken: OSM layers have never been supported by the offline service (we support WMS and WMTS).
59c485a
to
c4e92a7
Compare
"dependencies": {} | ||
"dependencies": { | ||
"localforage": "^1.7.3" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be in devDependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the indexedDB abstraction we use for the offline feature.
It can not be a dev dependency (we want it transitively) but maybe it could be an optional dependency? That would be our first one.
@@ -1,6 +1,8 @@ | |||
/** | |||
* @module ngeo.message.modalComponent | |||
*/ | |||
import 'jquery'; | |||
import 'jquery-ui'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also
969e6c4
to
c19561f
Compare
No description provided.