Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

703 - Set print layer zIndex to -200 #4387

Merged
merged 1 commit into from
Nov 19, 2018

Conversation

adube
Copy link
Contributor

@adube adube commented Nov 15, 2018

This patch sets the zIndex of the layers created by the GMF print component to -200, just like the the background layers.

The issue that was happening with Cartoriviera is that the "Plan Cadstral" BG layer has a child with "printLayers" defined. From what I understand this child is used when printing instead of the original first child. OpenLayers Layer object are created in the GMF print componnent, but were not given a zIndex, i.e. it stays as 0. When issuing a print requests, layers are ordered by zIndex, then reversed. That print layer was therefore put on top.

There's currently no way to test this using the demo server. I also don't have a lot of knowledge of the print tool, so I don't know if this will have an impact somewhere else.

@adube adube requested a review from sbrunner November 15, 2018 16:07
@adube
Copy link
Contributor Author

adube commented Nov 19, 2018

@sbrunner Ready for review.

@adube adube merged commit 3b94f64 into camptocamp:2.3 Nov 19, 2018
@adube adube deleted the v2_3-703-print-bg-layer branch November 19, 2018 20:28
@sbrunner sbrunner added this to the 2.3 milestone Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants