Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unwanted title in ngeo displaywindow component #4716

Merged

Conversation

adube
Copy link
Contributor

@adube adube commented Mar 5, 2019

For version 2.3

An issue happened with ngeo displaywindow components in desktop apps. A title was being shown with mainCtrl.displaywindowTitle as content when mouse hovering any of its content (close button, header, container, etc.)

gmfx.openIframePopup('page.html', 'My page', 500, 400);

This happens because the one of the component's options is title, which is a reserved attribute in HTML:

        <ngeo-displaywindow
          content="mainCtrl.displaywindowContent"
          desktop="true"
          draggable-containment="mainCtrl.displaywindowDraggableContainment"
          height="mainCtrl.displaywindowHeight"
          open="mainCtrl.displaywindowOpen"
          title="mainCtrl.displaywindowTitle" <------
          url="mainCtrl.displaywindowUrl"
          width="mainCtrl.displaywindowWidth"
        ></ngeo-displaywindow>

To bypass this issue, setting title="" in the template container div does the trick.

A better fix would be to change this option, but I think this should be addressed for v2.5 (as changing the name of an attribute would break the backward compatibility).

@adube adube merged commit 0b650d9 into camptocamp:2.3 Mar 6, 2019
@adube adube deleted the 2_3-822-fix-iframepopup-close-btn-title branch March 6, 2019 13:09
@adube
Copy link
Contributor Author

adube commented Mar 6, 2019

@sbrunner I'll let you merge the branch 2.3 to master to have this fix in 2.4 as well.

@sbrunner sbrunner added this to the 2.3 milestone Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants