Fix unwanted title in ngeo displaywindow component #4716
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For version 2.3
An issue happened with ngeo displaywindow components in desktop apps. A title was being shown with
mainCtrl.displaywindowTitle
as content when mouse hovering any of its content (close button, header, container, etc.)This happens because the one of the component's options is
title
, which is a reserved attribute in HTML:To bypass this issue, setting
title=""
in the template container div does the trick.A better fix would be to change this option, but I think this should be addressed for v2.5 (as changing the name of an attribute would break the backward compatibility).