Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export query window and grid controllers, to be able to extend them #4773

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Export query window and grid controllers, to be able to extend them #4773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions contribs/gmf/src/query/gridComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,13 +163,12 @@ module.component('gmfDisplayquerygrid', queryGridComponent);
* @param {!import("ngeo/download/Csv.js").DownloadCsvService} ngeoCsvDownload CSV download service.
* @param {!JQuery} $element Element.
* @constructor
* @private
* @hidden
* @ngInject
* @ngdoc controller
* @ngname GmfDisplayquerygridController
*/
function Controller($injector, $scope, ngeoQueryResult, ngeoMapQuerent,
export function Controller($injector, $scope, ngeoQueryResult, ngeoMapQuerent,
llienher marked this conversation as resolved.
Show resolved Hide resolved
ngeoFeatureOverlayMgr, $timeout, ngeoCsvDownload, $element) {

const queryOptions = /** @type {import('ngeo/query/MapQuerent.js').QueryOptions} */ (
Expand Down
3 changes: 1 addition & 2 deletions contribs/gmf/src/query/windowComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,12 @@ module.component('gmfDisplayquerywindow', queryWindowComponent);
* @param {!import("ngeo/map/FeatureOverlayMgr.js").FeatureOverlayMgr} ngeoFeatureOverlayMgr The ngeo feature
* overlay manager service.
* @constructor
* @private
* @hidden
* @ngInject
* @ngdoc controller
* @ngname GmfDisplayquerywindowController
*/
function Controller($element, $scope, ngeoQueryResult, ngeoMapQuerent, ngeoFeatureOverlayMgr) {
export function Controller($element, $scope, ngeoQueryResult, ngeoMapQuerent, ngeoFeatureOverlayMgr) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be named QueryWindowComponent...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about QueryWindowController ^^?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in this PR: #4775


/**
* @type {Element|string}
Expand Down