Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in api doc #4991

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Fix typo in api doc #4991

merged 1 commit into from
Jul 5, 2019

Conversation

pfirpfel
Copy link
Contributor

@pfirpfel pfirpfel commented Jul 4, 2019

No description provided.

@pfirpfel pfirpfel requested a review from sbrunner July 4, 2019 06:57
sbrunner
sbrunner approved these changes Jul 4, 2019
View reviewed changes
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be on 2.4?

@pfirpfel
Copy link
Contributor Author

pfirpfel commented Jul 4, 2019

It exists since 2.4, yes

@sbrunner sbrunner changed the base branch from master to 2.4 July 4, 2019 14:27
@sbrunner
Copy link
Member

sbrunner commented Jul 4, 2019 •
edited
Loading

Can you rebase it on 2.4?

@pfirpfel
Copy link
Contributor Author

pfirpfel commented Jul 4, 2019

done

@sbrunner
Copy link
Member

sbrunner commented Jul 4, 2019

Thanks, merge when Travis tests pass :-)

@pfirpfel pfirpfel merged commit 3dffbca into camptocamp:2.4 Jul 5, 2019
@pfirpfel pfirpfel deleted the fix-crosshair-typo branch July 5, 2019 06:27
@sbrunner sbrunner added this to the 2.4.2 milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@pfirpfel @sbrunner