fix(code) comply coding conventions

Signed-off-by: David Edler <david.edler@canonical.com>
canonical · Feb 20, 2024 · 625aa55 · 625aa55
1 parent d4abd51
commit 625aa55
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/src/components/Xterm.tsx b/src/components/Xterm.tsx
@@ -176,7 +176,7 @@ export default forwardRef<Terminal, Props>(function Xterm(
     if (onCursorMove) xtermRef.current.onCursorMove(onCursorMove);
     if (onData) xtermRef.current.onData(onData);
     if (onKey) xtermRef.current.onKey(onKey);
-    if (onLineFeed) xtermRef.current.onLineFeed;
+    if (onLineFeed) xtermRef.current.onLineFeed(onLineFeed);
     if (onScroll) xtermRef.current.onScroll(onScroll);
     if (onSelectionChange)
       xtermRef.current.onSelectionChange(onSelectionChange);

diff --git a/src/components/forms/NetworkDevicesForm.tsx b/src/components/forms/NetworkDevicesForm.tsx
@@ -51,7 +51,7 @@ const NetworkDevicesForm: FC<Props> = ({ formik, project }) => {
     queryFn: () => fetchNetworks(project),
   });
 
-  if (profileError) {
+  if (networkError) {
     notify.failure("Loading networks failed", networkError);
   }
 

diff --git a/src/context/toastNotificationProvider.tsx b/src/context/toastNotificationProvider.tsx
@@ -173,7 +173,7 @@ const ToastNotificationProvider: FC<PropsWithChildren> = ({ children }) => {
   };
 
   const latestNotification = notifications[notifications.length - 1];
-  const hasNotifications = !!notifications?.length;
+  const hasNotifications = !!notifications.length;
   const showNotification = hasNotifications && !showList && notificationTimer;
   const showNotificationList = hasNotifications && showList;
   return (

diff --git a/src/pages/images/CustomIsoSelector.tsx b/src/pages/images/CustomIsoSelector.tsx
@@ -72,7 +72,7 @@ const CustomIsoSelector: FC<Props> = ({
             <Button
               appearance={
                 primaryImage?.name === image.aliases &&
-                primaryImage.pool === image.pool
+                primaryImage?.pool === image.pool
                   ? "positive"
                   : ""
               }

diff --git a/src/pages/storage/CustomVolumeSelectModal.tsx b/src/pages/storage/CustomVolumeSelectModal.tsx
@@ -95,8 +95,8 @@ const CustomVolumeSelectModal: FC<Props> = ({
                     dense
                     appearance={
                       primaryVolume?.name === volume.name &&
-                      primaryVolume.type === volume.type &&
-                      primaryVolume.pool == volume.pool
+                      primaryVolume?.type === volume.type &&
+                      primaryVolume?.pool == volume.pool
                         ? "positive"
                         : ""
                     }