Skip to content

Commit

Permalink
fix(instance) ensure new creating instances are shown consistently du…
Browse files Browse the repository at this point in the history
…ring creation #549

Signed-off-by: David Edler <david.edler@canonical.com>
  • Loading branch information
edlerd authored and lorumic committed Nov 23, 2023
1 parent 17beeab commit af34763
Showing 1 changed file with 17 additions and 11 deletions.
28 changes: 17 additions & 11 deletions src/pages/instances/InstanceList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -130,18 +130,24 @@ const InstanceList: FC = () => {
}

const creationNames: string[] = [];
const creationOperations = (operationList?.running ?? []).filter(
(operation) => {
const isCreating =
operation.description === "Creating instance" &&
operation.status === "Running";
if (isCreating) {
const createInstanceName = getInstanceName(operation);
creationNames.push(createInstanceName);
const creationOperations = (operationList?.running ?? [])
.concat(operationList?.success ?? [])
.filter((operation) => {
const isCreating = operation.description === "Creating instance";
if (!isCreating) {
return false;
}
return isCreating;
},
);
const name = getInstanceName(operation);
const isInInstanceList = instances.some((item) => item.name === name);
const isRunning = operation.status === "Running";

if (!isRunning && isInInstanceList) {
return false;
}

creationNames.push(name);
return true;
});

const filteredInstances = instances.filter((item) => {
if (creationNames.includes(item.name)) {
Expand Down

0 comments on commit af34763

Please sign in to comment.