-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation on instance create #507
Conversation
Demo starting at https://lxd-ui-507.demos.haus |
c1213a7
to
1499e18
Compare
Hey @piperdeck See updated demo link above or the screencast link below for how it is now: Screencast.from.17.11.2023.13.39.19.webmEdit: I avoided moving the root storage to the main page of the form, because it would be hidden all the way on the bottom and look a little odd there with the table like view next to the regular form elements. |
3f20b80
to
d5874de
Compare
Discovered another area where we should catch missing information in instance config. When you create a network device for an instance, it enforces giving the network a name but doesn't actually enforce choosing a network for that network device. It lets you click "save changes" but then throws an error. We should make the "Network" field mandatory as well. |
…k device name and missing storage volume path canonical#485 Signed-off-by: David Edler <david.edler@canonical.com>
d5874de
to
e6222da
Compare
Good point! I think the solution is to auto-select the 1st network when a network is added. That way, the Network selector can't be in an invalid state. I just pushed a change to do that. Please give the PR another pass @piperdeck |
LGTM |
QA and code both looks good to me |
Done
Fixes #485
QA