-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submit in custom disk device creation modal improvements #544
Conversation
Demo starting at https://lxd-ui-544.demos.haus |
938bdb6
to
2277b9f
Compare
Otherwise, this looks good to me! |
2277b9f
to
4881140
Compare
Whoopsie, I think this is from a bad merge due to other PRs happening in parallel. Now it should be fine. Please have another pass at this PR @piperdeck |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA looks good! Two comments, not really critical so feel free to disregard them.
4881140
to
7f638c8
Compare
…n for instance modal Signed-off-by: David Edler <david.edler@canonical.com>
7f638c8
to
0e6df07
Compare
Done
QA