Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit in custom disk device creation modal improvements #544

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Nov 20, 2023

Done

  • improve behaviour of submit in custom disk device creation modal for the instance configuration

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • edit or create an instance
    • select disk devices > Attach disk device > Create volume
    • ensure the creation and selection works.
    • The "Create volume" form should render the create button busy after submit (used to be no indicator while loading)
    • Coming back to the "Choose custom volume" should
      • render the new volume on top (used to be in the middle, now sorted by most recent created)
      • initially show a loading state until the new volume is included (used to be hidden and updating in the background at some time)

@webteam-app
Copy link

Demo starting at https://lxd-ui-544.demos.haus

@piperdeck
Copy link

  • In the volume creation modal, the "storage pool" field seems to appear twice

Otherwise, this looks good to me!

@edlerd
Copy link
Collaborator Author

edlerd commented Nov 29, 2023

  • In the volume creation modal, the "storage pool" field seems to appear twice

Whoopsie, I think this is from a bad merge due to other PRs happening in parallel. Now it should be fine. Please have another pass at this PR @piperdeck

@piperdeck
Copy link

LGTM

Copy link
Collaborator

@mas-who mas-who left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA looks good! Two comments, not really critical so feel free to disregard them.

…n for instance modal

Signed-off-by: David Edler <david.edler@canonical.com>
@edlerd edlerd merged commit 4f47947 into canonical:main Dec 1, 2023
6 checks passed
@edlerd edlerd deleted the disk-volume-create-submit branch December 1, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants