Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage) default storage pool for volume creation [WD-7675] #573

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

mas-who
Copy link
Collaborator

@mas-who mas-who commented Dec 8, 2023

Done

  • When a user creates a new custom storage volume from the volumes list, and if they’ve filtered this list to only show volumes from one storage pool, the volume creation form will now set the storage pool to match the filter by default.

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Go to Storage -> Volumes tab. In the search and filter input box, filter volumes by a single storage pool. Then try create a volume, the storage pool selection should be defaulted to the filtered storage pool.
    • Now try filter volumes by multiple storage pools. Then try create a volume, the storage pool selection should be defaulted to the default storage pool. Same behaviour should be observed if there are no storage pool filters for volumes.

@webteam-app
Copy link

Demo starting at https://lxd-ui-573.demos.haus

Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA and code looks good to me.

@edlerd
Copy link
Collaborator

edlerd commented Dec 8, 2023

Might want to get a design review from @piperdeck as he suggested the change originally.

Signed-off-by: Mason Hu <mason.hu@canonical.com>
@mas-who mas-who force-pushed the default-storage-pool-on-filter branch from b4d1a58 to 4ac25bc Compare December 8, 2023 15:17
@piperdeck
Copy link

Everything looks good!

@mas-who mas-who merged commit 54bef42 into main Dec 12, 2023
6 checks passed
@edlerd edlerd deleted the default-storage-pool-on-filter branch December 12, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants