Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app) disable configurations when entity creation is blocked [WD-7489] #578

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

mas-who
Copy link
Collaborator

@mas-who mas-who commented Dec 11, 2023

Done

  • Fixed the issue with configuration side navigation items remaining accessible even when entity creation (i.e. instance, network, profile or storage volume) is blocked due to invalid form entries.

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • While creating an instance, select a base image so that configurations becomes available. Click on the Advanced drop down, then deselect the base image. The drop down should collapse and become disabled.
    • While creating a profile, enter a name for the profile so that configurations becomes available. Click on the Advanced drop down, then clear the profile name input field. The drop down should collapse and become disabled.
    • While creating a network, enter a name for the network so that configurations becomes available. Click on the Advanced drop down, then clear the network name input field. The drop down should collapse and become disabled.
    • While creating a storage volume, enter a name for the volume so that configurations becomes available. Click on the Advanced drop down, then clear the volume name input field. The drop down should collapse and become disabled.

Signed-off-by: Mason Hu <mason.hu@canonical.com>
@webteam-app
Copy link

Demo starting at https://lxd-ui-578.demos.haus

@mas-who mas-who changed the title fix(app) disable configurations when entity creation is blocked fix(app) disable configurations when entity creation is blocked [WD-7489] Dec 11, 2023
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this.

@edlerd edlerd merged commit f63bf32 into main Dec 12, 2023
6 checks passed
@edlerd edlerd deleted the create-entity-side-navigation branch December 12, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants