fix: switch back to pull_request event trigger for gh actions

.github/workflows/pr.yaml

@@ -1,11 +1,29 @@
 name: PR checks
-on: pull_request_target
+on: pull_request
 
 permissions:
   contents: read
 
 jobs:
 
+  commits:
+    permissions:
+      pull-requests: read   # to get list of commits from the PR
+    name: Canonical CLA signed and Signed-off-by (DCO)
+    runs-on: ubuntu-latest
+    steps:
+    - name: Check if CLA signed
+      uses: canonical/has-signed-canonical-cla@v1
+    - name: Get PR Commits
+      id: 'get-pr-commits'
+      uses: tim-actions/get-pr-commits@master
+      with:
+        token: ${{ secrets.GITHUB_TOKEN }}
+    - name: Check that all commits are signed-off
+      uses: tim-actions/dco@master
+      with:
+        commits: ${{ steps.get-pr-commits.outputs.commits }}
+
   lint-scss:
     runs-on: ubuntu-latest
 
@@ -138,56 +156,3 @@ jobs:
 
       - name: Run Javascript tests
         run: dotrun test-js
-
-  publish_report:
-    permissions:
-      contents: write
-    name: publish-e2e-report
-    # if job is cancelled we should skip this
-    if: success() || needs.e2e.outputs.job_status == 'failure'
-    needs: [e2e]
-    runs-on: ubuntu-latest
-    continue-on-error: true
-    env:
-      HTML_REPORT_URL_PATH: reports/pr-${{ github.event.number }}/${{ github.run_id }}/${{ github.run_attempt }}
-      PR_NUMBER: ${{ github.event.number }}
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          ref: gh-pages
-          token: ${{ secrets.GITHUB_TOKEN }}
-      # user git configs are needed for git commands to work
-      # actual authentication is done using secrets.GITHUB_TOKEN with write permission
-      - name: Set Git User
-        run: |
-          git config --global user.email "github-action@example.com"
-          git config --global user.name "GitHub Action"
-      - name: Download zipped HTML report
-        uses: actions/download-artifact@v4
-        with:
-          name: playwright-report
-          path: ${{ env.HTML_REPORT_URL_PATH }}
-      - name: Push HTML Report
-        timeout-minutes: 3
-        run: |
-          git add .
-          git commit -m "workflow: add HTML report for PR #$PR_NUMBER (run_id: ${{ github.run_id }}, attempt:  ${{ github.run_attempt }})"
-
-          # In case if another action job pushed to gh-pages while we are rebasing for the current job
-          while true; do
-            git pull --rebase
-            if [ $? -ne 0 ]; then
-              echo "Failed to rebase. Please review manually."
-              exit 1
-            fi
-
-            git push
-            if [ $? -eq 0 ]; then
-              echo "Successfully pushed HTML report to repo."
-              exit 0
-            fi
-          done
-      - name: Output Report URL as Worfklow Annotation
-        run: |
-          FULL_HTML_REPORT_URL=https://canonical.github.io/lxd-ui/$HTML_REPORT_URL_PATH
-          echo "::notice title=Published Playwright Test Report::$FULL_HTML_REPORT_URL"

src/components/ConfigurationRow.tsx

@@ -135,20 +135,20 @@ export const getConfigurationRow = ({
     override: isReadOnly
       ? overrideValue
       : isOverridden
-      ? getForm()
-      : wrapDisabledTooltip(
-          <Button
-            onClick={toggleDefault}
-            className="u-no-margin--bottom"
-            type="button"
-            disabled={disabled}
-            appearance="base"
-            title="Create override"
-            hasIcon
-          >
-            <Icon name="edit" />
-          </Button>,
-        ),
+        ? getForm()
+        : wrapDisabledTooltip(
+            <Button
+              onClick={toggleDefault}
+              className="u-no-margin--bottom"
+              type="button"
+              disabled={disabled}
+              appearance="base"
+              title="Create override"
+              hasIcon
+            >
+              <Icon name="edit" />
+            </Button>,
+          ),
   });
 };
 

src/pages/networks/NetworkDetailHeader.tsx

@@ -74,8 +74,8 @@ const NetworkDetailHeader: FC<Props> = ({ name, network, project }) => {
         !isManaged
           ? "Can not rename, network is not managed"
           : isUsed
-          ? "Can not rename, network is currently in use."
-          : undefined
+            ? "Can not rename, network is currently in use."
+            : undefined
       }
       controls={
         network && <DeleteNetworkBtn network={network} project={project} />

src/pages/networks/actions/DeleteNetworkBtn.tsx

@@ -45,8 +45,8 @@ const DeleteNetworkBtn: FC<Props> = ({ network, project }) => {
         !isManaged
           ? "Can not delete, network is not managed"
           : isUsed
-          ? "Can not delete, network is currently in use"
-          : "Delete network"
+            ? "Can not delete, network is currently in use"
+            : "Delete network"
       }
       confirmationModalProps={{
         title: "Confirm delete",

src/pages/storage/forms/StoragePoolFormMain.tsx

@@ -57,8 +57,8 @@ const StoragePoolFormMain: FC<Props> = ({ formik }) => {
             !formik.values.isCreating
               ? "Driver can't be changed"
               : formik.values.driver === zfsDriver
-              ? "ZFS gives best performance and reliability"
-              : undefined
+                ? "ZFS gives best performance and reliability"
+                : undefined
           }
           label="Driver"
           options={storageDrivers}

src/util/usedBy.tsx

@@ -49,12 +49,12 @@ export const filterUsedByType = (
         return a.project < b.project
           ? -1
           : a.project > b.project
-          ? 1
-          : a.name < b.name
-          ? -1
-          : a.name > b.name
-          ? 1
-          : 0;
+            ? 1
+            : a.name < b.name
+              ? -1
+              : a.name > b.name
+                ? 1
+                : 0;
       }) ?? []
   );
 };